szaszm commented on PR #2261: URL: https://github.com/apache/nifi-minifi-cpp/pull/2261#issuecomment-5640151120
Ownership of UA_NodeId is transferred to the RAII wrapper in its constructor, so I'd annotate the constructor parameter and the data member as owner. > Also, the id_ member is of type UA_NodeId, not UA_NodeId*, and gsl::owner can only be applied to a pointer type. I wasn't sure about this restriction, but if gsl::owner only applies to pointer types, then indeed we can't use it for this, and a comment is the best we can do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
