joewitt commented on PR #11271: URL: https://github.com/apache/nifi/pull/11271#issuecomment-5655841142
**What was true before the PR** `kafka-clients` and the Testcontainers image were already **4.3.1** on `main` (`kafka-clients.version` and `kafka.docker.image` in the parent POM; `AbstractKafkaBaseIT` / `Kafka3ConnectionServiceBaseIT` default to `apache/kafka:4.3.1`). Classic Consume/Publish ITs already ran against that broker. There was nothing to bump to 4.2.0. **What is true with the PR** Share ITs use that **same** 4.3.1 image. What actually changed is broker **config** on that image so share groups work: share in `group.coordinator.rebalance.protocols`, share coordinator enabled, share-coordinator topic RF/ISR for a single-node container, and a short `group.share.record.lock.duration.ms` (5s) for tests. The PR body still has a bullet: “Bump the integration-test broker to apache/kafka:4.2.0”. That reads as either a version bump that did not happen or a downgrade from 4.3.1 to 4.2.0. The share **product** requirement (4.1+ / 4.2+ GA brokers in the field) is a different statement and is already in `ConsumeKafka` docs; mixing it with “we changed the IT image to 4.2.0” is what is wrong. **What I propose specifically and why** Fix the PR summary bullet (and any leftover “we bumped ITs to 4.2.0” comments) to say: clients and Testcontainers stay on 4.3.1; this change only enables share on that broker. Otherwise reviewers will think the Kafka test matrix moved, and it did not. Broker 4.2 as the **minimum for Share Group in production** can stay in processor docs; that is KIP-932 GA, not the Docker tag used in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
