pvillard31 commented on PR #11271: URL: https://github.com/apache/nifi/pull/11271#issuecomment-5661289640
Thanks @joewitt for the detailed review. I pushed `25c5f29` with the following changes: - Added a broker-backed EXPLICIT-mode integration test that simulates a NiFi session commit failure through the actual `ConsumeKafka` failure callback. It verifies that the released Kafka record is redelivered with the same payload, topic, partition, and offset. - Renamed the IMPLICIT-mode integration test to clarify that it covers configuration and end-to-end delivery. The existing service unit tests remain the focused proof that implicit commit, rollback, and `acknowledge()` do not issue per-record Kafka acknowledgements. - Extracted the unsupported Share Consumer property removal into `stripShareUnsupportedConsumerConfigs(Properties)`. - Added parameterized coverage for all ten properties rejected by the bundled Kafka 4.3.1 Share Consumer and a test confirming that supported properties are preserved. I intentionally avoided reflection into Kafka's private configuration list, so future Kafka client upgrades still require reviewing this list explicitly. - Corrected the source comment and PR description: the restriction comes from the bundled `kafka-clients` implementation, not the broker version. The Kafka clients and Testcontainers image remain on 4.3.1; the integration setup only enables Share Group broker configuration on that image. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
