exceptionfactory commented on code in PR #11762:
URL: https://github.com/apache/nifi/pull/11762#discussion_r4196152943
##########
pom.xml:
##########
@@ -112,6 +112,10 @@
<docker.image.tag>21</docker.image.tag>
<docker.jdk.image.name>bellsoft/liberica-openjdk-debian</docker.jdk.image.name>
<docker.jre.image.name>bellsoft/liberica-openjre-debian</docker.jre.image.name>
+ <!-- Platform the container images are built for. Must name a
platform: docker-maven-plugin
+ only uses BuildKit when one is set, and uses the Docker Engine
API otherwise. The
+ docker-platform-arm64 profile below overrides this on arm64
hosts. -->
Review Comment:
This is helpful, but a bit verbose, recommend shortening as:
```suggestion
<!-- Default build platform architecture for Docker container images
-->
```
##########
pom.xml:
##########
@@ -1139,6 +1143,19 @@
</properties>
</profile>
+ <!-- Build container images for the host architecture instead of the
linux/amd64 default -->
Review Comment:
```suggestion
<!-- Alternative profile for ARM64 Docker build platform -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
