awelless commented on code in PR #11800:
URL: https://github.com/apache/nifi/pull/11800#discussion_r4250071872
##########
nifi-extension-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/test/java/org/apache/nifi/services/protobuf/TestStandardProtobufWriterConfluentRoundTrip.java:
##########
@@ -73,9 +73,16 @@
*/
class TestStandardProtobufWriterConfluentRoundTrip {
- private static final int SCHEMA_ID = 42;
+ private static final long SCHEMA_ID = 42;
// Confluent header: magic byte 0x00 followed by the big-endian schema id
(42).
private static final byte[] EXPECTED_HEADER = {0x00, 0x00, 0x00, 0x00,
0x2A};
+ private static final int HEADER_LENGTH = EXPECTED_HEADER.length;
+
+ private static final String REGISTRY_ID = "registry";
Review Comment:
The extraction of the variables was suggested during the previous
protobuf-related PR https://github.com/apache/nifi/pull/11710.
Since I added 2 more test cases here, I decided to move the variables into
constants along the way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
