anshuksi282-ksolves opened a new pull request, #11802:
URL: https://github.com/apache/nifi/pull/11802

   ## Summary
   [NIFI-15857](https://issues.apache.org/jira/browse/NIFI-15857)
   
   The overlapping connections banner added in NIFI-15654 is always displayed 
while overlapping connections exist, which is a nuisance for flows where 
overlapping connections are intentional.
   
   This adds a Dismiss button to the banner. Dismissal is kept in component 
state only, in line with the other dismissible
   banners in the UI, and the banner is displayed again when the set of 
overlapping connections changes.
   
   Tests in `overlapping-connections-banner.component.spec.ts` cover hiding the 
banner on dismiss, showing it again when the overlapping connections change, 
and keeping it hidden when the same overlapping connections are re-evaluated.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-00000`
   - [x] Pull request contains [commits 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
 with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   The frontend was verified with `nx test nifi` for the banner and canvas 
specs, `nx lint nifi` and Prettier. NiFi was
   also assembled with `./mvnw install -DskipTests -pl nifi-assembly -am` on 
JDK 21 and started locally.
   
   ### Licensing
   
   - [x] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   No new dependencies were added.
   
   ### Documentation
   
   - [x] Documentation formatting appears as expected in rendered files
   
   No documentation files were changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to