anshuksi282-ksolves commented on PR #11802: URL: https://github.com/apache/nifi/pull/11802#issuecomment-6145862474
> > The overlapping connections banner added in [NIFI-15654](https://issues.apache.org/jira/browse/NIFI-15654) is always displayed while overlapping connections exist, which is a nuisance for flows where overlapping connections are intentional. > > @anshuksi282-ksolves Why is intentionally overlapping connections desirable? IIRC the overlapping logic only considers connections overlapping if they have no additional bend points. So connections are overlapping when they have the same source and destination. In this case, the connection label is placed in the middle of both connections right on top of each other. This blocks the label making it impossible to see the queue details of the label underneath. If you truly want the connections right on top of each other, you could always add a bend point to one of the connections. This should allow the connections to not be considered overlapping and additionally allows you to not miss the connection label. Thanks for the review. The use case in the description comes from the reporter of NIFI-15857, not from me, and I should have worded the summary as the reporter's request rather than as a given. I agree with your point: overlapping connections hide the label and queue details of the one underneath, and a bend point separates them and clears the banner, which is also what the banner text suggests. I'll leave it to you and the reporter to decide whether a Dismiss button is still wanted. If the preferred resolution is the bend point workaround, I'm happy to close this PR and the Jira issue can be resolved accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
