lordgamez commented on code in PR #2284:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2284#discussion_r4258472225


##########
extensions/kafka/tests/PublishKafkaTests.cpp:
##########
@@ -55,4 +60,39 @@ TEST_CASE("Trigger without valid broker", "[PublishKafka]") {
   CHECK_FALSE(logger->logs_.empty());
 }
 
+namespace {
+bool hasDebugLog(const mock::MockLogger& logger, std::string_view message) {
+  const auto debug_logs = logger.logs_.find(core::logging::LOG_LEVEL::debug);
+  return debug_logs != logger.logs_.end() && 
std::ranges::any_of(debug_logs->second, [&](const auto& log) { return 
log.contains(message); });

Review Comment:
   We compile with c++23 standard and require compilers g++ 13 or greater, 
clang 20 or greater, or msvc 19.33 or greater, all of them should have this 
c++23 feature implemented.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to