lordgamez commented on code in PR #2284:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2284#discussion_r4258493027
##########
extensions/kafka/tests/CMakeLists.txt:
##########
@@ -25,6 +25,7 @@ FOREACH (testfile ${KAFKA_INTEGRATION_TESTS})
add_minifi_executable("${testfilename}" "${testfile}")
target_include_directories(${testfilename} BEFORE PRIVATE
"${CMAKE_SOURCE_DIR}/extensions/kafka")
target_compile_definitions(${testfilename} PRIVATE
"MINIFI_EXTENSION_GROUP_NAME=org.apache.nifi.minifi.test")
+ target_compile_definitions(${testfilename} PRIVATE
TEST_RESOURCES="${TEST_RESOURCES}")
Review Comment:
We had no problems with this on multiple platforms and TEST_RESOURCES are
passed this way in all tests. We may improve on this in the future but this is
not the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
