Copilot commented on code in PR #2302: URL: https://github.com/apache/nifi-minifi-cpp/pull/2302#discussion_r4549179379
########## cmake/Couchbase.cmake: ########## @@ -52,6 +52,10 @@ FetchContent_Declare(couchbase-cxx-client ) FetchContent_MakeAvailable(couchbase-cxx-client) +if (WIN32) Review Comment: `_SILENCE_CXX20_OLD_SHARED_PTR_ATOMIC_SUPPORT_DEPRECATION_WARNING` is specific to MSVC’s STL. `WIN32` can also be true for non-MSVC toolchains (e.g., MinGW, clang targeting GNU libstdc++), and applying MSVC STL-specific silencing globally on Windows can be misleading. Prefer guarding on `MSVC` (or `CMAKE_CXX_COMPILER_ID STREQUAL "MSVC"` / `MSVC` + `CMAKE_CXX_SIMULATE_ID` for clang-cl) instead of `WIN32`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
