lordgamez commented on code in PR #2302:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2302#discussion_r4549213556


##########
cmake/Couchbase.cmake:
##########
@@ -52,6 +52,10 @@ FetchContent_Declare(couchbase-cxx-client
 )
 FetchContent_MakeAvailable(couchbase-cxx-client)
 
+if (WIN32)

Review Comment:
   We only test and support MSVC on Windows, and have the same condition for 
deprecation warning silencing for GCP as well, so this should be okay.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to