adamdebreceni commented on code in PR #2231:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2231#discussion_r4562632377
##########
core-framework/include/core/Resource.h:
##########
@@ -73,6 +74,11 @@ class StaticClassType {
auto factory =
std::unique_ptr<controller::ControllerServiceFactory>(new
controller::ControllerServiceFactoryImpl<Class>(module_name));
getClassLoader().registerClass(construction_name, std::move(factory));
}
+ } else if constexpr (Type == ResourceType::ReportingTask) {
+ for (const auto& construction_name : construction_names_) {
+ auto factory = std::unique_ptr<reporting::ReportingTaskFactory>(new
reporting::ReportingTaskFactoryImpl<Class>(module_name));
+ getClassLoader().registerClass(construction_name, std::move(factory));
Review Comment:
changed all 4 to make_unique
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
