lordgamez commented on code in PR #2231:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2231#discussion_r4586246345


##########
minifi-api/include/minifi-cpp/core/ProcessContext.h:
##########
@@ -46,14 +47,20 @@ class ProcessorInfo {
 
 class Processor;
 
-class ProcessContext : public virtual core::VariableRegistry, public virtual 
utils::EnableSharedFromThis {
+class ProcessContext : public reporting::ReportingTaskContext, public virtual 
core::VariableRegistry, public virtual utils::EnableSharedFromThis {

Review Comment:
   It is not a specific property, but in the context of the domain the IS-A 
relationship is invalid. When we are talking about the ReportingTaskContext it 
is specific to reporting tasks and should not be the base class of a 
ProcessContext which should be specific to processors. We could argue that the 
reporting task is a specialized processor, but it does not make sense the other 
around. I didn't comment on this, but I think there should be a clear 
separation between processors and reporting tasks even if their API is similar. 
I see that it would be a larger task as currently the scheduler only works with 
processors and the reporting task is handled as such, so it would require a 
larger redesign which could be discussed in the future. But at least we should 
not mix them further when it is not necessary, hence ProcessContext should not 
be a specialized ReportingTaskContext.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to