fgerlits commented on code in PR #2304:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2304#discussion_r4563331660
##########
core-framework/include/core/ThreadedRepository.h:
##########
@@ -80,13 +80,13 @@ class ThreadedRepositoryImpl : public core::RepositoryImpl,
public virtual core:
return running_state_.load() == RunningState::Running;
}
- BackTrace getTraces() override {
+ utils::trace_resolver::BackTrace getTraces() override {
// If the thread is joinable then it is finished, we cannot interrupt and
collect its stack traces
// It can occur with an empty run() implementation like the
NoOpThreadedRepository where the stack trace is unavailable
if (getThread().joinable()) {
Review Comment:
This sounds reasonable; although it is slightly out of scope, I will look
into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
