fgerlits commented on code in PR #2304:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2304#discussion_r4586002883


##########
libminifi/test/unit/CMakeLists.txt:
##########
@@ -37,4 +37,11 @@ FOREACH(testfile ${UNIT_TESTS})
 ENDFOREACH()
 message("-- Finished building ${UNIT_TEST_COUNT} unit test file(s)...")
 
+if (NOT WIN32)
+    set_target_properties(BackTraceTests PROPERTIES ENABLE_EXPORTS ON)
+    if (APPLE)

Review Comment:
   I have looked into this: on Linux, CMake adds `-Wl,-export-dynamic` 
automatically if `ENABLE_EXPORTS` is set, and on MacOS, `-rdynamic` gets 
translated to `-Wl,-export-dynamic` on all but very old `ld64` versions.  So 
the code is fine as it is, both here and in 
`libminifi/test/integration/extension-verification-test/CMakeLists.txt`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to