[
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905576#comment-15905576
]
ASF GitHub Bot commented on NIFI-3585:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1584
NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-3585
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1584.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1584
----
commit 30efa7234185ee2c059a326e9f4c62d8b6c1cffc
Author: Matt Burgess <mattyb...@apache.org>
Date: 2017-03-10T19:16:07Z
NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008
----
> DB Adapter for MS SQL 2008
> --------------------------
>
> Key: NIFI-3585
> URL: https://issues.apache.org/jira/browse/NIFI-3585
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Minor
> Fix For: 1.2.0
>
>
> NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL
> Server 2012+, it is not compatible with MS SQL 2008 because of its use of
> OFFSET and FETCH, e.g.
> This case is to introduce support for earlier versions of SQL Server to the
> database fetching processors such as QueryDatabaseTable and
> GenerateTableFetch. It may be the case that the generated SQL is awkward and
> less-than-ideal (more like Oracle's pagination query), but this will enable
> those processors to interact with SQL Server versions prior to 2012.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
