[ 
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935165#comment-15935165
 ] 

ASF GitHub Bot commented on NIFI-3585:
--------------------------------------

Github user jfrazee commented on the issue:

    https://github.com/apache/nifi/pull/1584
  
    @mattyb149 Ok LGTM now so +1
    
    I tested with 
[NIFI-3585.xml](https://gist.github.com/jfrazee/63fc76f25bc5cdcfaf66d246cf232d19)
 on an Amazon RDS SQL Server instance using the Orders table + OrderID column 
in the Northwind database [1,2,3].
    
    1. https://northwinddatabase.codeplex.com
    2. 
http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/SQLServer.Procedural.Importing.html#SQLServer.Procedural.Importing.Native.Using.Restore
    3. 
https://aws.amazon.com/blogs/database/migrating-microsoft-sql-server-enterprise-workloads-to-amazon-rds-part-1/


> DB Adapter for MS SQL 2008
> --------------------------
>
>                 Key: NIFI-3585
>                 URL: https://issues.apache.org/jira/browse/NIFI-3585
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.2.0
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL 
> Server 2012+, it is not compatible with MS SQL 2008 because of its use of 
> OFFSET and FETCH, e.g.
> This case is to introduce support for earlier versions of SQL Server to the 
> database fetching processors such as QueryDatabaseTable and 
> GenerateTableFetch. It may be the case that the generated SQL is awkward and 
> less-than-ideal (more like Oracle's pagination query), but this will enable 
> those processors to interact with SQL Server versions prior to 2012.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to