[ 
https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962262#comment-15962262
 ] 

ASF GitHub Bot commented on NIFI-3633:
--------------------------------------

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1610#discussion_r110550270
  
    --- Diff: nifi-bootstrap/pom.xml ---
    @@ -34,13 +34,26 @@ language governing permissions and limitations under 
the License. -->
                 <artifactId>nifi-utils</artifactId>
             </dependency>
             <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-security-utils</artifactId>
    +        </dependency>
    +        <dependency>
                 <groupId>javax.mail</groupId>
                 <artifactId>mail</artifactId>
             </dependency>
             <dependency>
                 <groupId>org.apache.nifi</groupId>
                 <artifactId>nifi-expression-language</artifactId>
             </dependency>
    +        <dependency>
    +            <groupId>com.squareup.okhttp3</groupId>
    +            <artifactId>okhttp</artifactId>
    --- End diff --
    
    The only dep that's brought in is "okio" (as shown in the previous 
comment). I did forget to add it to the rpm plugin build, adding it to the new 
commit.


> Create an HttpNotifierService implementation of the Bootstrap Notification 
> Service
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-3633
>                 URL: https://issues.apache.org/jira/browse/NIFI-3633
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Joseph Witt
>             Fix For: 1.2.0
>
>
> In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects 
> that it has died unexpectedly" the bootstrap has the notification service but 
> currently there is only one implementation, the EmailNotifierService[1]. 
> An HttpNotifierService should be created in order to more generically post 
> notifications. 
> [1] 
> https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to