[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985933#comment-15985933 ]
ASF GitHub Bot commented on NIFI-3633: -------------------------------------- GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1705 NIFI-3633 Adding a try with resources so the OkHttp response is prope… …rly closed Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi NIFI-3633_2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1705.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1705 ---- commit 102fbb6facd32525c56901ffd7b2ae1c3002a03b Author: Joe Percivall <jperciv...@apache.org> Date: 2017-04-27T02:23:30Z NIFI-3633 Adding a try with resources so the OkHttp response is properly closed ---- > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > ---------------------------------------------------------------------------------- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement > Reporter: Joseph Percivall > Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)