Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118830045
  
    --- Diff: libminifi/src/Configure.cpp ---
    @@ -71,12 +71,31 @@ const char *Configure::nifi_security_client_pass_phrase 
=
         "nifi.security.client.pass.phrase";
     const char *Configure::nifi_security_client_ca_certificate =
         "nifi.security.client.ca.certificate";
    +const char *Configure::nifi_configuration_listener_pull_interval =
    +    "nifi.configuration.listener.pull.interval";
    +const char *Configure::nifi_configuration_listener_http_url =
    +    "nifi.configuration.listener.http.url";
    +const char *Configure::nifi_configuration_listener_rest_url =
    +    "nifi.configuration.listener.rest.url";
    +const char *Configure::nifi_configuration_listener_type =
    +    "nifi.configuration.listener.type";
    +const char *Configure::nifi_configuration_listener_need_ClientAuth =
    +    "nifi.configuration.listener.need.ClientAuth";
    +const char *Configure::nifi_configuration_listener_client_certificate =
    --- End diff --
    
    there are a lot of duplicate options here. it's possible that users will 
want to use different certs for different applications, which we should 
support; however, if consumers are using the same certificate perhaps we could 
make the configuration less onerous on them by tying configs together. this may 
make the eventual C2 impl easier to configure as well. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to