Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118822209
  
    --- Diff: libminifi/src/FlowController.cpp ---
    @@ -175,7 +211,7 @@ void FlowController::stop(bool force) {
         this->flow_file_repo_->stop();
         this->provenance_repo_->stop();
         // Wait for sometime for thread stop
    -    std::this_thread::sleep_for(std::chrono::milliseconds(1000));
    +    std::this_thread::sleep_for(std::chrono::milliseconds(3000));
    --- End diff --
    
    the sleep here seems arbitrary. why was 3 seconds chosen?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to