[GitHub] nifi-minifi-cpp pull request #107: Configuration listener

[phrocker]

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r118830027
  
    --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
    @@ -32,16 +32,25 @@ namespace core {
     core::ProcessGroup *YamlConfiguration::parseRootProcessGroupYaml(
         YAML::Node rootFlowNode) {
       uuid_t uuid;
    +  int64_t version = 0;
     
       checkRequiredField(&rootFlowNode, "name", 
CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY);
       std::string flowName = rootFlowNode["name"].as<std::string>();
       std::string id = getOrGenerateId(&rootFlowNode);
       uuid_parse(id.c_str(), uuid);
     
    -  logger_->log_debug("parseRootProcessGroup: id => [%s], name => [%s]", id,
    -                     flowName);
    +  if (rootFlowNode["version"]) {
    +    std::string value = rootFlowNode["version"].as<std::string>();
    +    if (core::Property::StringToInt(value, version)) {
    +      logger_->log_debug("parseRootProcessorGroup: version => [%d]", 
version);
    +    }
    +  }
    +
    +  logger_->log_debug(
    --- End diff --
    
    thanks for using the string. i saw a few places where it was id.c_str() if 
you could make them consistent that would be awesome. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---