Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123504131
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -76,27 +89,20 @@ void
RemoteProcessorGroupPort::returnProtocol(std::unique_ptr<Site2SiteClientPro
void RemoteProcessorGroupPort::initialize() {
// Set the supported properties
std::set<core::Property> properties;
- properties.insert(hostName);
- properties.insert(port);
properties.insert(portUUID);
setSupportedProperties(properties);
// Set the supported relationships
std::set<core::Relationship> relationships;
relationships.insert(relation);
setSupportedRelationships(relationships);
+ curl_global_init(CURL_GLOBAL_DEFAULT);
--- End diff --
the function is not thread safe. initialization isn't guaranteed to be
thread safe either since other components could initialize concurrently. It's
probably fine for now but seems like this should be done in a thread safe way.
https://curl.haxx.se/libcurl/c/curl_global_init.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
