Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123501252
  
    --- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
    @@ -344,7 +427,8 @@ int 
Site2SiteClientProtocol::readRequestType(RequestType &type) {
       return -1;
     }
     
    -int Site2SiteClientProtocol::readRespond(RespondCode &code, std::string 
&message) {
    +int Site2SiteClientProtocol::readRespond(RespondCode &code,
    --- End diff --
    
    Why the change in the function prototype? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to