Github user yuri1969 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1946#discussion_r124115889
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
 ---
    @@ -166,8 +178,17 @@ protected PropertyDescriptor 
getSupportedDynamicPropertyDescriptor(final String
                     .build();
         }
     
    -    private Templates newTemplates(String path) throws 
TransformerConfigurationException {
    +    private Templates newTemplates(ProcessContext context, String path) 
throws TransformerConfigurationException {
    +        final Boolean secureProcessing = 
context.getProperty(SECURE_PROCESSING).asBoolean();
             TransformerFactory factory = TransformerFactory.newInstance();
    +
    +        if (secureProcessing) {
    +            factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, 
true);
    +            // don't be overly DTD-unfriendly forcing 
http://apache.org/xml/features/disallow-doctype-decl
    +            
factory.setFeature("http://saxon.sf.net/feature/parserFeature?uri=http://xml.org/sax/features/external-parameter-entities";,
 false);
    --- End diff --
    
    The URL is Saxon's (horrible) feature name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to