Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1946#discussion_r124117608
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -98,6 +99,16 @@
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.build();
+ public static final PropertyDescriptor SECURE_PROCESSING = new
PropertyDescriptor.Builder()
+ .name("secure-processing")
+ .displayName("Secure processing")
+ .description("Whether or not to mitigate various XML-related
attacks like XXE (XML External Entity) attacks.")
+ .required(true)
+ .defaultValue("true")
--- End diff --
I'm not sure if there's an official backwards-compatibility policy, but I
think to be safe, when adding new (optional) functionality via a processor
property, the default value should match the existing behavior (in this case
false).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
