Github user Wesley-Lawrence commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2003#discussion_r127263693
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVReader.java
 ---
    @@ -49,7 +51,7 @@
         + "the values. See Controller Service's Usage for further 
documentation.")
     public class CSVReader extends SchemaRegistryService implements 
RecordReaderFactory {
     
    -    private final AllowableValue headerDerivedAllowableValue = new 
AllowableValue("csv-header-derived", "Use String Fields From Header",
    +    static final AllowableValue HEADER_DERIVED_ALLOWABLE_VALUE = new 
AllowableValue("csv-header-derived", "Use String Fields From Header",
    --- End diff --
    
    I figured leaving it package-private would let others access it as I've 
been accessing other `AllowableValue`s out of CSVUtils. I can set this to 
`private` if that's preferred, just let me know =)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to