Github user Wesley-Lawrence commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2003#discussion_r127265959
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVRecordSetWriter.java
 ---
    @@ -48,6 +54,7 @@
         @Override
         protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
             final List<PropertyDescriptor> properties = new 
ArrayList<>(super.getSupportedPropertyDescriptors());
    +        properties.add(CSVUtils.EXPLICIT_COLUMNS);
    --- End diff --
    
    Hmm. I'll take a stab at defining the new functionality in the 
`@capabilitydescription` in both `CSVReader` and `CSVRecordSetWriter`. 
    
    I think It's worth documenting, and explaining in `CSVReader` that columns 
can be renamed by using "Explicit Columns". As well as explaining in 
`CSVRecordSetWriter` that "Explicit Columns" doesn't rename columns, but does 
allow for re-ordering, while reminding users that the column names have been 
defined by whatever RecordReader is being used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to