Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137824349
  
    --- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
    @@ -43,14 +44,15 @@ class RemoteProcessorGroupPort : public core::Processor 
{
       /*!
        * Create a new processor
        */
    -  RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory> 
&stream_factory, std::string name, std::string url, std::shared_ptr<Configure> 
configure, uuid_t uuid = nullptr)
    +  RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory> 
&stream_factory, std::string name, std::string url, const 
std::shared_ptr<Configure> &configure, uuid_t uuid = nullptr)
           : core::Processor(name, uuid),
             configure_(configure),
             direction_(SEND),
             transmitting_(false),
    +        timeout_(0),
             
logger_(logging::LoggerFactory<RemoteProcessorGroupPort>::getLogger()),
             url_(url),
    -        securityConfig_(configure) {
    +        
ssl_service(std::make_shared<controllers::SSLContextService>("RemoteProcessorGroupPortSSLContextService",
 configure)) {
    --- End diff --
    
    Should we be using a ControllerServiceProvider here rather than 
constructing the SSLContextService directly?


---

Reply via email to