Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137587733
  
    --- Diff: libminifi/include/core/state/metrics/SystemMetrics.h ---
    @@ -0,0 +1,111 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#ifndef LIBMINIFI_INCLUDE_CORE_STATE_METRICS_SYSMETRICS_H_
    +#define LIBMINIFI_INCLUDE_CORE_STATE_METRICS_SYSMETRICS_H_
    +
    +#include "core/Resource.h"
    +#include <sstream>
    +#include <map>
    +#ifndef _WIN32
    +#include <sys/utsname.h>
    +#endif
    +#include "MetricsBase.h"
    +#include "Connection.h"
    +#include "DeviceInformation.h"
    +namespace org {
    +namespace apache {
    +namespace nifi {
    +namespace minifi {
    +namespace state {
    +namespace metrics {
    +
    +/**
    + * Justification and Purpose: Provides Connection queue metrics. Provides 
critical information to the
    + * C2 server.
    --- End diff --
    
    Docs here seem to be mismatched with the class. This class is for system 
metrics, not queue metrics.


---

Reply via email to