Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137811526 --- Diff: libminifi/include/FlowController.h --- @@ -124,14 +123,33 @@ class FlowController : public core::controller::ControllerServiceProvider, publi virtual bool isRunning() { return running_.load(); } + // Whether the Flow Controller has already been initialized (loaded flow XML) virtual bool isInitialized() { return initialized_.load(); } // Start to run the Flow Controller which internally start the root process group and all its children - virtual bool start(); + virtual int16_t start(); + virtual int16_t pause() { + return -1; + } // Unload the current flow YAML, clean the root process group and all its children - virtual void stop(bool force); + virtual int16_t stop(bool force, uint64_t timeToWait = 0); + virtual int16_t applyUpdate(const std::string &configuration); + virtual int16_t drainRepositories() { + + return -1; + } + + virtual std::vector<std::shared_ptr<state::StateController>> getComponents(const std::string &name); + + virtual std::vector<std::shared_ptr<StateController>> getAllComponents(); --- End diff -- Missing state:: prefix on StateController type makes this signature declaration inconsistent with its implementation/other uses. Mostly cosmetic?
---