Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/14#discussion_r142515496
  
    --- Diff: 
nifi-registry-security/src/main/java/org/apache/nifi/registry/authorization/AccessPolicy.java
 ---
    @@ -0,0 +1,367 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.registry.authorization;
    +
    +import java.nio.charset.StandardCharsets;
    +import java.util.Collections;
    +import java.util.HashSet;
    +import java.util.Objects;
    +import java.util.Set;
    +import java.util.UUID;
    +
    +/**
    + * Defines a policy for a set of userIdentifiers to perform a set of 
actions on a given resource.
    + */
    +public class AccessPolicy {
    --- End diff --
    
    It's a good suggestion. I wasn't thrilled with the current organization. 
Your approach both distinguishes interfaces from implementation and adds 
extensibility. Will make that change, thanks!


---

Reply via email to