[GitHub] nifi-registry pull request #14: NIFIREG-9: Initial Auth Implementation

[kevdoran]

Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/14#discussion_r142516827
  
    --- Diff: 
nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/RegistryService.java
 ---
    @@ -261,6 +262,29 @@ public Bucket deleteBucket(final String 
bucketIdentifier) {
             }
         }
     
    +    public List<BucketItem> getBucketItems(final QueryParameters 
queryParameters, final Set<String> bucketIdentifiers) {
    +        if (bucketIdentifiers == null || bucketIdentifiers.isEmpty()) {
    +            throw new IllegalArgumentException("Bucket Identifiers cannot 
be null or empty");
    +        }
    +
    +        readLock.lock();
    +        try {
    +            final Set<BucketEntity> filterBuckets = 
bucketIdentifiers.stream()
    --- End diff --
    
    Yeah I agree that would be a better approach. Will make that change, thanks.


---