[ 
https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400876#comment-16400876
 ] 

ASF GitHub Bot commented on NIFI-4935:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2523#discussion_r174825845
  
    --- Diff: 
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access/HortonworksAttributeSchemaReferenceStrategy.java
 ---
    @@ -84,7 +85,8 @@ public RecordSchema getSchema(Map<String, String> 
variables, final InputStream c
             final long schemaId = Long.parseLong(schemaIdentifier);
             final int version = Integer.parseInt(schemaVersion);
    --- End diff --
    
    Shouldn't we be supporting the use of a Branch Name instead of a Version 
here? I.e., should we support using either version OR branch name?


> Support Schema Branches when using HWX Schema Registry
> ------------------------------------------------------
>
>                 Key: NIFI-4935
>                 URL: https://issues.apache.org/jira/browse/NIFI-4935
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>
> The latest version of Hortonworks Schema Registry now supports a 
> forking/branching concept. This means that when retrieving a schema by name, 
> it may be desirable to also specify a branch name, as the default would 
> retrieve from the "master" branch. We'll need to pass down an optional branch 
> name to the SchemaRegistry implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to