[ 
https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400919#comment-16400919
 ] 

ASF GitHub Bot commented on NIFI-4935:
--------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2523#discussion_r174888711
  
    --- Diff: 
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/StandardSchemaIdentifier.java
 ---
    @@ -64,6 +75,49 @@ public boolean equals(final Object obj) {
                 return false;
             }
             final SchemaIdentifier other = (SchemaIdentifier) obj;
    -        return getName().equals(other.getName()) && 
getIdentifier().equals(other.getIdentifier()) && 
getVersion().equals(other.getVersion());
    +        return getName().equals(other.getName())
    +                && getIdentifier().equals(other.getIdentifier())
    +                && getVersion().equals(other.getVersion())
    +                && getBranch().equals(other.getBranch());
    +    }
    +
    +    /**
    +     * Builder to create instances of Schema
    --- End diff --
    
    Will update


> Support Schema Branches when using HWX Schema Registry
> ------------------------------------------------------
>
>                 Key: NIFI-4935
>                 URL: https://issues.apache.org/jira/browse/NIFI-4935
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>
> The latest version of Hortonworks Schema Registry now supports a 
> forking/branching concept. This means that when retrieving a schema by name, 
> it may be desirable to also specify a branch name, as the default would 
> retrieve from the "master" branch. We'll need to pass down an optional branch 
> name to the SchemaRegistry implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to