[ 
https://issues.apache.org/jira/browse/NIFI-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402426#comment-16402426
 ] 

ASF GitHub Bot commented on NIFI-3599:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2497#discussion_r175195219
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ConfigDTO.java
 ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.web.api.dto;
    +
    +import io.swagger.annotations.ApiModelProperty;
    +
    +import javax.xml.bind.annotation.XmlType;
    +
    +/**
    + * Contains configuration information for this NiFi.
    + */
    +@XmlType(name = "config")
    +public class ConfigDTO {
    +
    +    private String backPressureObjectThreshold;
    +    private String backPressureDataSizeThreshold;
    --- End diff --
    
    Should we rename these `defaultBackPressureObjectThreshold` and  
`defaultBackPressureDataSizeThreshold`? Also, we can make the 
`defaultBackPressureObjectThreshold` a `Long`.


> Add nifi.properties value to globally set the default backpressure size 
> threshold for each connection
> -----------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3599
>                 URL: https://issues.apache.org/jira/browse/NIFI-3599
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Configuration
>            Reporter: Jeremy Dyer
>            Assignee: Michael Moser
>            Priority: Major
>
> By default each new connection added to the workflow canvas will have a 
> default backpressure size threshold of 10,000 objects. While the threshold 
> can be changed on a connection level it would be convenient to have a global 
> mechanism for setting that value to something other than 10,000. This 
> enhancement would add a property to nifi.properties that would allow for this 
> threshold to be set globally unless otherwise overridden at the connection 
> level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to