[ 
https://issues.apache.org/jira/browse/NIFI-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402427#comment-16402427
 ] 

ASF GitHub Bot commented on NIFI-3599:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2497#discussion_r175197796
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowFileQueue.java
 ---
    @@ -139,6 +137,36 @@ public StandardFlowFileQueue(final String identifier, 
final Connection connectio
     
             readLock = new TimedLock(this.lock.readLock(), identifier + " Read 
Lock", 100);
             writeLock = new TimedLock(this.lock.writeLock(), identifier + " 
Write Lock", 100);
    +
    +        NiFiProperties nifiProps = 
NiFiProperties.createBasicNiFiProperties(null, null);
    --- End diff --
    
    This current approach will load the properties file every time a connection 
is created. Can we follow the approach that was taken with the 
`queueSwapThreshold` instead? Usually, this sort of parsing logic is in 
`NiFiProperties` so that `getBackPressureObjectThreshold` and 
`getBackPressureDataSizeThreshold` return the parsed value. 


> Add nifi.properties value to globally set the default backpressure size 
> threshold for each connection
> -----------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3599
>                 URL: https://issues.apache.org/jira/browse/NIFI-3599
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Configuration
>            Reporter: Jeremy Dyer
>            Assignee: Michael Moser
>            Priority: Major
>
> By default each new connection added to the workflow canvas will have a 
> default backpressure size threshold of 10,000 objects. While the threshold 
> can be changed on a connection level it would be convenient to have a global 
> mechanism for setting that value to something other than 10,000. This 
> enhancement would add a property to nifi.properties that would allow for this 
> threshold to be set globally unless otherwise overridden at the connection 
> level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to