[ 
https://issues.apache.org/jira/browse/NIFI-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408598#comment-16408598
 ] 

ASF GitHub Bot commented on NIFI-4198:
--------------------------------------

Github user arunma commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2094#discussion_r176242220
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchHttpProcessor.java
 ---
    @@ -97,6 +116,27 @@
     
         private final AtomicReference<OkHttpClient> 
okHttpClientAtomicReference = new AtomicReference<>();
     
    +    private static final List<PropertyDescriptor> propertyDescriptors;
    +
    +    static {
    +        final List<PropertyDescriptor> properties = new ArrayList<>();
    +        properties.add(ES_URL);
    --- End diff --
    
    Thanks @mattyb149 - I was not sure about what stand to make too.  I added 
them in the Abstract as a matter of convenience and to avoid duplication . 
Please let me know if you have any strong reservations, in which case, I'll go 
ahead and add it to all the inherited processors. 


> *ElasticsearchHttp processors do not expose Proxy settings
> ----------------------------------------------------------
>
>                 Key: NIFI-4198
>                 URL: https://issues.apache.org/jira/browse/NIFI-4198
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Andre F de Miranda
>            Assignee: Arun Manivannan
>            Priority: Major
>         Attachments: NIFI-4198-ElasticProxy-TestFixtures.pdf, 
> NIFI-4198-ElasticProxy.xml
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to