[ 
https://issues.apache.org/jira/browse/NIFI-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408604#comment-16408604
 ] 

ASF GitHub Bot commented on NIFI-4198:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2094#discussion_r176243205
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchHttpProcessor.java
 ---
    @@ -97,6 +116,27 @@
     
         private final AtomicReference<OkHttpClient> 
okHttpClientAtomicReference = new AtomicReference<>();
     
    +    private static final List<PropertyDescriptor> propertyDescriptors;
    +
    +    static {
    +        final List<PropertyDescriptor> properties = new ArrayList<>();
    +        properties.add(ES_URL);
    --- End diff --
    
    I like them in the abstract class, but I believe they are also being added 
in some of the inherited processors IIRC. Also do you mind rebasing your PR 
against the latest master? There appear to be some merge conflicts. Please and 
thanks!


> *ElasticsearchHttp processors do not expose Proxy settings
> ----------------------------------------------------------
>
>                 Key: NIFI-4198
>                 URL: https://issues.apache.org/jira/browse/NIFI-4198
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Andre F de Miranda
>            Assignee: Arun Manivannan
>            Priority: Major
>         Attachments: NIFI-4198-ElasticProxy-TestFixtures.pdf, 
> NIFI-4198-ElasticProxy.xml
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to