[ https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535074#comment-16535074 ]
ASF GitHub Bot commented on NIFI-5376: -------------------------------------- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r200703862 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java --- @@ -264,7 +263,7 @@ private static void unpack(final File nar, final File workingDirectory, final by String name = jarEntry.getName(); File f = new File(workingDirectory, name); if (jarEntry.isDirectory()) { - FileUtils.ensureDirectoryExistAndCanAccess(f); + FileUtils.ensureDirectoryExistAndCanReadAndWrite(f); --- End diff -- this looks like a change fixing a bug whereby we checked for simple access instead of ability to write files. Can we link this to an existing JIRA or expand the scope of NIFI-5376 so we dont lose track of this. > Remove deprecated ByteArrayInput|OutputStream references throughout project > --------------------------------------------------------------------------- > > Key: NIFI-5376 > URL: https://issues.apache.org/jira/browse/NIFI-5376 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework > Affects Versions: 1.7.0 > Reporter: Andy LoPresto > Assignee: Andy LoPresto > Priority: Major > Labels: deprecated, warnings > > The Maven build produces numerous deprecation warnings because of references > to deprecated custom versions of > {{org.apache.nifi.stream.io.ByteArrayInputStream}} and > {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced > with > {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. > {code} > [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ > nifi-utils --- > [INFO] Changes detected - recompiling the module! > [INFO] Compiling 14 source files to > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,55] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[84,22] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[84,55] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[134,35] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)