[ https://issues.apache.org/jira/browse/NIFI-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537908#comment-16537908 ]
ASF GitHub Bot commented on NIFI-5376: -------------------------------------- Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2841#discussion_r201202337 --- Diff: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java --- @@ -107,12 +102,9 @@ * * @return a Transaction to use for sending or receiving data, or * <code>null</code> if all nodes are penalized. - * @throws org.apache.nifi.remote.exception.HandshakeException he - * @throws org.apache.nifi.remote.exception.PortNotRunningException pnre - * @throws IOException ioe - * @throws org.apache.nifi.remote.exception.UnknownPortException upe + * @throws IOException if unable to determine the identifier of the port */ - Transaction createTransaction(TransferDirection direction) throws HandshakeException, PortNotRunningException, ProtocolException, UnknownPortException, IOException; --- End diff -- I agree; will revert this change. I think opening a separate Jira to discuss error handling (and enforcing consistent behavior across the application) is a good idea. > Remove deprecated ByteArrayInput|OutputStream references throughout project > --------------------------------------------------------------------------- > > Key: NIFI-5376 > URL: https://issues.apache.org/jira/browse/NIFI-5376 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework > Affects Versions: 1.7.0 > Reporter: Andy LoPresto > Assignee: Andy LoPresto > Priority: Major > Labels: deprecated, warnings > > The Maven build produces numerous deprecation warnings because of references > to deprecated custom versions of > {{org.apache.nifi.stream.io.ByteArrayInputStream}} and > {{org.apache.nifi.stream.io.ByteArrayOutputStream}}. These should be replaced > with > {{java.io.ByteArrayInputStream}} and {{java.io.ByteArrayOutputStream}}. > {code} > [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ > nifi-utils --- > [INFO] Changes detected - recompiling the module! > [INFO] Compiling 14 source files to > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/target/test-classes > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[19,32] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[20,32] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[28,67] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[29,50] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[35,67] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[36,50] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[42,67] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/LimitingInputStreamTest.java:[43,56] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,14] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[43,47] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,22] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[62,54] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,22] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[64,55] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[84,22] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[84,55] > [deprecation] ByteArrayOutputStream in org.apache.nifi.stream.io has been > deprecated > [WARNING] > /Users/alopresto/Workspace/nifi/nifi-commons/nifi-utils/src/test/java/org/apache/nifi/stream/io/TestLeakyBucketThrottler.java:[134,35] > [deprecation] ByteArrayInputStream in org.apache.nifi.stream.io has been > deprecated > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)