Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3010#discussion_r219293897
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/node/NodeClusterCoordinator.java
 ---
    @@ -821,7 +878,9 @@ void notifyOthersOfNodeStatusChange(final 
NodeConnectionStatus updatedStatus, fi
             // Otherwise, get the active coordinator (or wait for one to 
become active) and then notify the coordinator.
             final Set<NodeIdentifier> nodesToNotify;
             if (notifyAllNodes) {
    -            nodesToNotify = 
getNodeIdentifiers(NodeConnectionState.CONNECTED, 
NodeConnectionState.CONNECTING);
    +            // TODO notify all nodes
    --- End diff --
    
    I think we can remove this TODO and the line below it.


---

Reply via email to