[GitHub] nifi pull request #3010: [WIP] NIFI-5585

[markap14]

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3010#discussion_r219294399
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/heartbeat/TestAbstractHeartbeatMonitor.java
 ---
    @@ -244,11 +245,26 @@ public synchronized void 
finishNodeConnection(NodeIdentifier nodeId) {
                 statuses.put(nodeId, new NodeConnectionStatus(nodeId, 
NodeConnectionState.CONNECTED));
             }
     
    +        @Override
    +        public synchronized void finishNodeDecommission(NodeIdentifier 
nodeId) {
    +            statuses.put(nodeId, new NodeConnectionStatus(nodeId, 
NodeConnectionState.DECOMMISSIONED));
    +        }
    +
    +        @Override
    +        public synchronized void requestNodeDecommission(NodeIdentifier 
nodeId, DecommissionCode decommissionCode, String explanation) {
    +            statuses.put(nodeId, new NodeConnectionStatus(nodeId, 
NodeConnectionState.DECOMMISSIONED));
    +        }
    +
             @Override
             public synchronized void requestNodeDisconnect(NodeIdentifier 
nodeId, DisconnectionCode disconnectionCode, String explanation) {
                 statuses.put(nodeId, new NodeConnectionStatus(nodeId, 
NodeConnectionState.DISCONNECTED));
             }
     
    +//        @Override
    --- End diff --
    
    Can remove.


---