Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3122#discussion_r230300635
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLogMessage.java
 ---
    @@ -57,7 +57,7 @@ MockComponentLog getMockComponentLog() {
         public void before() throws InitializationException {
             testableLogMessage = new TestableLogMessage();
             runner = TestRunners.newTestRunner(testableLogMessage);
    -
    +        runner.setValidateExpressionUsage(false);
    --- End diff --
    
    In that case I'm not sure to understand the intent of this PR. Initially I 
thought it was about removing 
``.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)`` 
on ``LOG_LEVEL`` since the property only accepts a list of allowed values. If 
we do that, then we should remove the  
``.evaluateAttributeExpressions(flowFile)``, no?
    
    On the other hand, if we do want to allow EL on this property, then the 
property and code should be changed to allow free text value that is validated 
against the list of allowed values only if EL is not used. And then if EL is 
used, there should be a default behavior in case the value, after EL 
evaluation, is not an allowed value.
    
    Am I missing something?


---

Reply via email to