[GitHub] nifi pull request #3122: NIFI-5777: Update the tag and the property of LogMe...

[ijokarumawak]

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3122#discussion_r230526767
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLogMessage.java
 ---
    @@ -57,7 +57,7 @@ MockComponentLog getMockComponentLog() {
         public void before() throws InitializationException {
             testableLogMessage = new TestableLogMessage();
             runner = TestRunners.newTestRunner(testableLogMessage);
    -
    +        runner.setValidateExpressionUsage(false);
    --- End diff --
    
    Sorry for the confusion. I was just looking at the source code. When I run 
the processor, I realized that the processor doesn't allow EL. The logLevel is 
shown as a free text input, and I can input EL, but validation failed because 
of the configured allowable values.
    
    I still think changing log level by EL would be nice:
    
![image](https://user-images.githubusercontent.com/1107620/47943878-b191ff80-df3b-11e8-9456-939900b53e0e.png)
    
    My suggestion is, changing:
    
    ```
                .description("The Log Level to use when logging the message")
                .allowableValues(MessageLogLevel.values())
    ```
    
    to 
    
    ```
                .description("The Log Level to use when logging the message: " 
+ Arrays.toString(MessageLogLevel.values()))
                .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    ```
    
    How do you guys think?


---