[
https://issues.apache.org/jira/browse/NIFI-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672765#comment-16672765
]
ASF GitHub Bot commented on NIFI-5777:
--------------------------------------
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3122#discussion_r230300635
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLogMessage.java
---
@@ -57,7 +57,7 @@ MockComponentLog getMockComponentLog() {
public void before() throws InitializationException {
testableLogMessage = new TestableLogMessage();
runner = TestRunners.newTestRunner(testableLogMessage);
-
+ runner.setValidateExpressionUsage(false);
--- End diff --
In that case I'm not sure to understand the intent of this PR. Initially I
thought it was about removing
``.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)``
on ``LOG_LEVEL`` since the property only accepts a list of allowed values. If
we do that, then we should remove the
``.evaluateAttributeExpressions(flowFile)``, no?
On the other hand, if we do want to allow EL on this property, then the
property and code should be changed to allow free text value that is validated
against the list of allowed values only if EL is not used. And then if EL is
used, there should be a default behavior in case the value, after EL
evaluation, is not an allowed value.
Am I missing something?
> Update the tag and the property of LogMessage
> ---------------------------------------------
>
> Key: NIFI-5777
> URL: https://issues.apache.org/jira/browse/NIFI-5777
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Kotaro Terada
> Assignee: Kotaro Terada
> Priority: Major
>
> There are a few points to update in {{LogMessage}}:
> * The processor tags are a little bit strange. The current tags are
> "attributes" and "logging". A tag "attributes" is not suitable for this
> processor. I suggest just "logging" is enough.
> * The property "Log Level" should be selected using a drop-down list (as it
> is done in {{LogAttribute}}). Currently, the field is just a text box, and
> users need to type a log level manually. If we set "expression language
> supported" on the property, does it force to make the property become a text
> field in the Web UI?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
