[
https://issues.apache.org/jira/browse/NIFI-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673770#comment-16673770
]
ASF GitHub Bot commented on NIFI-5777:
--------------------------------------
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3122#discussion_r230526767
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLogMessage.java
---
@@ -57,7 +57,7 @@ MockComponentLog getMockComponentLog() {
public void before() throws InitializationException {
testableLogMessage = new TestableLogMessage();
runner = TestRunners.newTestRunner(testableLogMessage);
-
+ runner.setValidateExpressionUsage(false);
--- End diff --
Sorry for the confusion. I was just looking at the source code. When I run
the processor, I realized that the processor doesn't allow EL. The logLevel is
shown as a free text input, and I can input EL, but validation failed because
of the configured allowable values.
I still think changing log level by EL would be nice:
My suggestion is, changing:
```
.description("The Log Level to use when logging the message")
.allowableValues(MessageLogLevel.values())
```
to
```
.description("The Log Level to use when logging the message: "
+ Arrays.toString(MessageLogLevel.values()))
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
```
How do you guys think?
> Update the tag and the property of LogMessage
> ---------------------------------------------
>
> Key: NIFI-5777
> URL: https://issues.apache.org/jira/browse/NIFI-5777
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Kotaro Terada
> Assignee: Kotaro Terada
> Priority: Major
>
> There are a few points to update in {{LogMessage}}:
> * The processor tags are a little bit strange. The current tags are
> "attributes" and "logging". A tag "attributes" is not suitable for this
> processor. I suggest just "logging" is enough.
> * The property "Log Level" should be selected using a drop-down list (as it
> is done in {{LogAttribute}}). Currently, the field is just a text box, and
> users need to type a log level manually. If we set "expression language
> supported" on the property, does it force to make the property become a text
> field in the Web UI?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
