Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3128#discussion_r230812123
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
 ---
    @@ -265,6 +265,17 @@
                 
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
                 .build();
     
    +    static final PropertyDescriptor BATCH_SIZE = new 
PropertyDescriptor.Builder()
    +            .name("put-db-record-batch-size")
    +            .displayName("Bulk Size")
    +            .description("Specifies batch size for INSERT and UPDATE 
statements. This parameter has no effect for other statements specified in 
'Statement Type'."
    +                    + " Non-positive value has the effect of infinite bulk 
size.")
    +            .defaultValue("-1")
    --- End diff --
    
    What does a value of zero do? Would anyone ever use it? If not, perhaps 
zero is the best default to indicate infinite bulk size. If you do change it to 
zero, please change the validator to a NONNEGATIVE_INTEGER_VALIDATOR to match


---

Reply via email to