Github user patricker commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3128#discussion_r231153599
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
 ---
    @@ -669,11 +685,20 @@ private void executeDML(ProcessContext context, 
ProcessSession session, FlowFile
                             }
                         }
                         ps.addBatch();
    +                    if (++currentBatchSize == batchSize) {
    --- End diff --
    
    True, I missed that override before, but I see it now. So definitely less 
valuable, the only thing it would provide would be troubleshooting guidance, 
"your bad data is roughly in this part of the file". Probably not worth it. 
Thanks!


---

Reply via email to