Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454#discussion_r238631364
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -325,6 +325,12 @@ void
YamlConfiguration::parseRemoteProcessGroupYaml(YAML::Node *rpgNode, core::P
}
}
}
+ } else if (transport_protocol == "RAW") {
+ group->setTransportProtocol(transport_protocol);
+ } else {
+ std::stringstream stream;
+ stream << "Invalid transport protocol " << transport_protocol;
+ throw minifi::Exception(ExceptionType::SITE2SITE_EXCEPTION,
stream.str().c_str());
--- End diff --
This is fine, however makes me wonder why don't we have string param ctr.
for minifi::Exception as we convert to the const char* to string anyway in the
current ctr.
---
